SecurityTip: Deny by Default
This is a nice article on how a hacker stole $31M of Ethereum (cryptocurrency). It explains why Ethereum is different from Bitcoin, something I hadn't known, and explains how the hack worked and how it was thwarted. Well-written and worth a read for the more deeply curious.
The one quibble with the article is that the author states, "Mistakes of this sort are routinely made in programming.". That's true, of course, but a platitude and not a good excuse. Ethereum is special, and standard security rules should apply when building dispatch mechanisms. The author notes that "The safer approach here would be to whitelist specific methods that the user is allowed to call." Yes, always dispatch with a whitelist or some affirmative action on the part of the programmer. The default is deny, not allow. A quick search found an article from CERT that points to a 1975 article that in turn mentions the principle was first suggested by E. Glaser in 1965.
A while ago I write an article on dispatch, don't decorate, where I mention that you should use patterns for dispatch. It's a subtle mention, because the point of the article is about using dispatch not decorators. If the Ethereum author had used a pattern-match for allow instead of a pattern match for deny ("internal"), this problem would not have occurred.
Here's what we do in what we do in Sirepo for method dispatch in the server:
The pattern here is FUNC_PREFIX, which is "api_" so only methods that begin with "api_" would be called. That's the "whitelist" that the article's author talks about. You don't need a whitelist as that has to be maintained and audited. What you want is a name that identifies the function as a dispatch item. There are some subtleties in choosing the name. It contains an underscore so that it doesn't collide with builtins in Python. It doesn't begin with an underscore so we know it is a public method. Note also that "func_for_api" asserts the object is a function (not some other callable). And, if the method has some bug, it'll not dispatch (return the method) by default. That's pointed out in the CERT article as well.
Dispatch is key programming nowadays. Just make sure it requires the programmer to state explicitly that the dispatch is allowed.
Via Rob 07/21/2017
Major Release Syndrome: A Case for Chronological VersioningSecurityTip: Deny by DefaultDigital Name Management: Own Your Name SpaceHow to Safely and Easily Manage PasswordsHow To Detect Phishing EmailsFacebook is a NOPServiceReview: InstacartBe Cheerful, Hopeful, GritfulDispatch, Don't DecorateVexillological Design LessonsLazy InvestingUS Government Cloud Computing Technology RoadmapBookReview: The Logic of Scientific DiscoveryBuild Identity Through Hard ChoicesBookReview: How to Fail at Almost Everything and Still Win Big: Kind of the Story of My LifePythonTip: "import from" Considered HarmfulBackpacking: Lost Creek WildernessNuclear Deterrence For Your CloudBookReview: Startup CEO: A Field Guide to Scaling Up Your
BusinessBookReview: The Structure of Scientific Revolutions (3rd Edition)The Psychology of Software TestingOwn VirtuallyBookReview: Fool's Gold: How the Bold Dream of a Small Tribe at J.P. Morgan Was Corrupted by Wall Street Greed and Unleashed a CatastropheBookReview: How to Be Alone: EssaysBookReview: Eat, Pray, Love▶ More▲ Most Recent
|back to top||© 2018 Rob Nagler||Software by bivio|